daren.hsu/webhook
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #9 from moorereason/vet

Browse Source 
Cleanups from static analyzers
This commit is contained in:
Adnan Hajdarević 2015-03-19 16:31:24 +01:00
commit 10755eb9d9
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
helpers/helpers.go
View File

@ -42,12 +42,10 @@ func ExtractParameter(s string, params interface{}) (string, bool) {
return "", false return "", false
} }
var p []string
if paramsValue := reflect.ValueOf(params); paramsValue.Kind() == reflect.Slice { if paramsValue := reflect.ValueOf(params); paramsValue.Kind() == reflect.Slice {
if paramsValueSliceLength := paramsValue.Len(); paramsValueSliceLength > 0 { if paramsValueSliceLength := paramsValue.Len(); paramsValueSliceLength > 0 {
if p = strings.SplitN(s, ".", 3); len(p) > 3 { if p := strings.SplitN(s, ".", 3); len(p) > 3 {
index, err := strconv.ParseInt(p[1], 10, 64) index, err := strconv.ParseInt(p[1], 10, 64)
if err != nil { if err != nil {
@ -63,7 +61,7 @@ func ExtractParameter(s string, params interface{}) (string, bool) {
return "", false return "", false
} }
if p = strings.SplitN(s, ".", 2); len(p) > 1 { if p := strings.SplitN(s, ".", 2); len(p) > 1 {
if pValue, ok := params.(map[string]interface{})[p[0]]; ok { if pValue, ok := params.(map[string]interface{})[p[0]]; ok {
return ExtractParameter(p[1], pValue) return ExtractParameter(p[1], pValue)
} }

9
webhook.go
View File

@ -93,18 +93,17 @@ func main() {
} }
} }
l := log.New(os.Stdout, "[webhook] ", log.Ldate|log.Ltime) l := negroni.NewLogger()
l.Logger = log.New(os.Stdout, "[webhook] ", log.Ldate|log.Ltime)
negroniLogger := &negroni.Logger{l}
negroniRecovery := &negroni.Recovery{ negroniRecovery := &negroni.Recovery{
Logger: l, Logger: l.Logger,
PrintStack: true, PrintStack: true,
StackAll: false, StackAll: false,
StackSize: 1024 * 8, StackSize: 1024 * 8,
} }
n := negroni.New(negroniRecovery, negroniLogger) n := negroni.New(negroniRecovery, l)
router := mux.NewRouter() router := mux.NewRouter()