daren.hsu/webhook
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix unnecessary nil check around range

Browse Source
This commit is contained in:
Cameron Moore 2018-02-16 20:36:42 -06:00
parent d85ee5e068
commit 66a9e48e39
1 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
webhook.go
View File

@ -250,11 +250,10 @@ func hookHandler(w http.ResponseWriter, r *http.Request) {
} }
// handle hook // handle hook
if errors := matchedHook.ParseJSONParameters(&headers, &query, &payload); errors != nil { errors := matchedHook.ParseJSONParameters(&headers, &query, &payload)
for _, err := range errors { for _, err := range errors {
log.Printf("[%s] error parsing JSON parameters: %s\n", rid, err) log.Printf("[%s] error parsing JSON parameters: %s\n", rid, err)
} }
}
var ok bool var ok bool
@ -341,28 +340,22 @@ func handleHook(h *hook.Hook, rid string, headers, query, payload *map[string]in
cmd.Dir = h.CommandWorkingDirectory cmd.Dir = h.CommandWorkingDirectory
cmd.Args, errors = h.ExtractCommandArguments(headers, query, payload) cmd.Args, errors = h.ExtractCommandArguments(headers, query, payload)
if errors != nil {
for _, err := range errors { for _, err := range errors {
log.Printf("[%s] error extracting command arguments: %s\n", rid, err) log.Printf("[%s] error extracting command arguments: %s\n", rid, err)
} }
}
var envs []string var envs []string
envs, errors = h.ExtractCommandArgumentsForEnv(headers, query, payload) envs, errors = h.ExtractCommandArgumentsForEnv(headers, query, payload)
if errors != nil {
for _, err := range errors { for _, err := range errors {
log.Printf("[%s] error extracting command arguments for environment: %s\n", rid, err) log.Printf("[%s] error extracting command arguments for environment: %s\n", rid, err)
} }
}
files, errors := h.ExtractCommandArgumentsForFile(headers, query, payload) files, errors := h.ExtractCommandArgumentsForFile(headers, query, payload)
if errors != nil {
for _, err := range errors { for _, err := range errors {
log.Printf("[%s] error extracting command arguments for file: %s\n", rid, err) log.Printf("[%s] error extracting command arguments for file: %s\n", rid, err)
} }
}
for i := range files { for i := range files {
tmpfile, err := ioutil.TempFile(h.CommandWorkingDirectory, files[i].EnvName) tmpfile, err := ioutil.TempFile(h.CommandWorkingDirectory, files[i].EnvName)