From 6c77ff0a2ce84a58ea533a1f433401cbd2d1ee55 Mon Sep 17 00:00:00 2001 From: Cameron Moore Date: Wed, 18 Sep 2019 16:59:11 -0500 Subject: [PATCH] Fix TestWebhook tests PR #266 appears to have changed the default response code to StatusOK. waitForServerReady() was expected a StatusNotFound response, which was preventing all TestWebhook tests from running. --- webhook_test.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/webhook_test.go b/webhook_test.go index 6113b9b..a1f8fc4 100644 --- a/webhook_test.go +++ b/webhook_test.go @@ -76,7 +76,6 @@ func TestWebhook(t *testing.T) { for _, tt := range hookHandlerTests { t.Run(tt.desc, func(t *testing.T) { - ip, port := serverAddress(t) args := []string{fmt.Sprintf("-hooks=%s", configPath), fmt.Sprintf("-ip=%s", ip), fmt.Sprintf("-port=%s", port), "-verbose"} @@ -249,7 +248,7 @@ func serverAddress(t *testing.T) (string, string) { func waitForServerReady(t *testing.T, ip, port string) { waitForServer(t, fmt.Sprintf("http://%v:%v/", ip, port), - http.StatusNotFound, + http.StatusOK, 5*time.Second) }